This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(sidenav): fix is-locked-open backdrop and incorrect backdrop tests #7790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The md-is-locked-open class-selector wasn't valid, because it wasn't probably privatized * The disabled backdrop tests, weren't valid, because the the sidenav wasn't actually opening. Fixes angular#7537
|
LGTM. Nice catch. |
gmoothart
pushed a commit
to gmoothart/material
that referenced
this pull request
Apr 5, 2016
* The md-is-locked-open class-selector wasn't valid, because it wasn't probably privatized * The disabled backdrop tests, weren't valid, because the the sidenav wasn't actually opening. Fixes angular#7537 Closes angular#7790
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KUDOS to @EladBezalel for his unbeatable help!
Fixes #7537