This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(menu): resolve an error when going from a nested menu item to a regular one #7826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egular one Fixes a JS error that was being thrown if the user goes from a menu item with a sub menu to an item that doesn't have one. Also fixes the menu item without a sub menu staying highlighted afterwards. Closes angular#7819.
|
lgtm |
ThomasBurleson
added
pr: merge ready
ilovett
pushed a commit
to ilovett/material
that referenced
this pull request
Apr 22, 2016
…egular one Fixes a JS error that was being thrown if the user goes from a menu item with a sub menu to an item that doesn't have one. Also fixes the menu item without a sub menu staying highlighted afterwards. Closes angular#7819. Closes angular#7826
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a JS error that was being thrown if the user goes from a menu item with a sub menu to an item that doesn't have one.
Also fixes the menu item without a sub menu staying highlighted afterwards.
Closes #7819.
@topherfangio Could you give me some feedback on this one? I believe it got introduced in b58343c#diff-7d56e0ee8b5aa2a3434f4f53a8a66168