This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(select): md-checkbox inside md-list-item using incorrect text color. #7893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekLouie
force-pushed
the
fixingAttributeSelectorInSelect
branch
from
3df57b1 to
7bdeba3
Compare
|
LGTM |
EladBezalel
added
needs: manual testing
|
LGTM @devversion please test manually |
|
@EladBezalel Yep, this works as expected and fixes the ripple text color side-effect. |
devversion
added
pr: merge ready
ilovett
pushed a commit
to ilovett/material
that referenced
this pull request
Apr 22, 2016
jelbourn
pushed a commit
that referenced
this pull request
Apr 28, 2016
ThomasBurleson
pushed a commit
that referenced
this pull request
May 17, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
@ThomasBurleson @devversion @EladBezalel.
I used an attribute selector which is not picked up by theming service which made some text miss-colored. Here is the fix + screenshot.
Fixes #7885.
Please Review.