This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(css): identify md components for global md styling #7942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertmesserle - please review |
ThomasBurleson
force-pushed
the
wip/global_md_indicator
branch
from
65751af to
ed8501d
Compare
| @@ -104,6 +104,8 @@ function GridListDirective($interpolate, $mdConstant, $mdGridLayout, $mdMedia) { | |||
| }; | |||
|
|
|||
| function postLink(scope, element, attrs, ctrl) { | |||
| attr.$addClass('_md'); // private md component indicator for styling | |||
There was a problem hiding this comment.
shouldn't this be attrs based on the previous line?
There was a problem hiding this comment.
or more accurately: shouldn't the previous line be attr?
There was a problem hiding this comment.
@robertmesserle - great catch.
|
Other than the one comment, LGTM. |
ThomasBurleson
force-pushed
the
wip/global_md_indicator
branch
from
ed8501d to
c6d3d36
Compare
|
@EladBezalel - please review. |
|
Why don't you use Other than that LGTM |
|
@EladBezalel - what is wrong with using |
|
@ThomasBurleson nothing wrong, just not natural imo.. |
* add private classname "._md" to all md component containers to all global md-only stylings * button-theme `<a>` styles now support `._md a:not(.md-button)` to style anchor tags used inside md containers * add unit tests to check for presence of `._md` classname
ThomasBurleson
force-pushed
the
wip/global_md_indicator
branch
from
c6d3d36 to
890af4a
Compare
ilovett
pushed a commit
to ilovett/material
that referenced
this pull request
Apr 22, 2016
* add private classname "._md" to all md component containers to all global md-only stylings * button-theme `<a>` styles now support `._md a:not(.md-button)` to style anchor tags used inside md containers * add unit tests to check for presence of `._md` classname Closes angular#7942
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<a>styles now support._md a:not(.md-button)to style anchor tags used inside md containers