This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): clickable list-items should show a focus effect. #7964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the focus effect was completely disabled for clickable list-items, because there were problems with the dialog focus restore. This focus effect, should be re-enabled on the clickable list items. But we should also keep track of the dialog focus restore issue. (See angular#7963) Fixes angular#7960.
ilovett
pushed a commit
to ilovett/material
that referenced
this pull request
Apr 22, 2016
* Currently the focus effect was completely disabled for clickable list-items, because there were problems with the dialog focus restore. This focus effect, should be re-enabled on the clickable list items. But we should also keep track of the dialog focus restore issue. (See angular#7963) Fixes angular#7960. Closes angular#7964
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This focus effect, should be re-enabled on the clickable list items.
But we should also keep track of the dialog focus restore issue. (See #7963)
Fixes #7960.
cc. @robertmesserle