This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(list): Correct avatar/icon size/spacing. #8053
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topherfangio
added
needs: review
|
@topherfangio LGTM |
| @@ -267,11 +268,19 @@ md-list-item { | |||
| box-sizing: content-box; | |||
| } | |||
| & .md-avatar { | |||
| flex: none; | |||
There was a problem hiding this comment.
Truly odd requirement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatars and icons within the lists had incorrect sizing/spacing on iOS due to some flex issues and incorrect
height: 100%calculation on the SVG.Tested on Desktop Chrome/Firefox/Safari/Edge/IE and iOS Safari/Chrome. Could use some manual testing on Android versions.