This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(virtual-repeat): auto shrink restored wrong original size. #8095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This broke the autocompletes height determination, when the matches array is empty. Fixes angular#7955.
|
Looks good |
ThomasBurleson
added
the
pr: merge ready
ThomasBurleson
removed
the
needs: review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kseamon Please review.
Also I want to appeal to you, to test it locally as well.
I already did it thoroughly but the bug before seemed to appear randomly, so I want a second person to look over it.
Fixes #7955.