fix(tooltip): interpolate the tooltip text when adding it to the aria-label #8170
Conversation
| // doesn't need to be set up if the element doesn't have any data | ||
| // bindings. | ||
| if (element.text().indexOf($interpolate.startSymbol()) > -1) { | ||
| scope.$watch(function() { |
There was a problem hiding this comment.
Huge performance impact with large lists where each item as a tooltip.
This is why we did the mutation observer... this $watch( ) here my re-introduce perf issues.
There was a problem hiding this comment.
Alright, I'll try to rework it and keep this one as a fallback for the case where a mutation observer isn't supported.
There was a problem hiding this comment.
A question about the mutation observer: In order to get it to fire for text changes, the characterData and subtree options need to be enabled. This fires the observer roughly twice as often as before. I think this might end up being slower than the watcher because we'll be calling the function that sets aria-label about 5 times on mouseover and about 5 times again on mouseleave.
ThomasBurleson
added
needs: work
and removed
needs: review
crisbeto
added
the
needs: feedback
crisbeto
added
needs: review
|
Relabelling as per our discussion. |
…-label Fixes the raw tooltip text text being added to the parent, if a tooltip contained a data binding, instead of the interpolated value. Fixes angular#6855.
crisbeto
force-pushed
the
fix/tooltip-aria
branch
from
2858a43 to
b865714
Compare
Fixes the raw tooltip text text being added to the parent, if a tooltip contained a data binding, instead of the interpolated value.
Fixes #6855.