Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-separator-keys ignores shift, other modifiers #8319

Closed
vbraun opened this issue May 3, 2016 · 1 comment
Closed

md-separator-keys ignores shift, other modifiers #8319

vbraun opened this issue May 3, 2016 · 1 comment
Labels
has: Pull Request A PR has been created to address this issue
Milestone
Deprecated

Comments

@vbraun
Copy link

vbraun commented May 3, 2016

Actual behavior:

  • What is the issue? md-separator-keys ignores shift, other modifiers
  • What is the expected behavior? Only the given separator keys should be used to separate chips, not combinations with key modifiers.

CodePen or Steps to reproduce the issue: *

  • CodePen Demo which shows your issue : https://material.angularjs.org/HEAD/demo/chips
  • Details: The official "Custom Separator Keys" demo sets up comma as separator, but also shift+comma separates. On an English/Dvorak keyboard, this is the "<" key. On a Danish keyboard, this is the "æ" key. This makes it impossible to enter chips containing these characters.

Angular Versions: *

  • Angular Version: 1.5.5
  • Angular Material Version: HEAD, 1.0.7

Additional Information:

  • Browser Type: Chrome, Firefox
  • Browser Version: Chrome 50, Firefox 45
  • OS: Linux, OSX
  • Stack Traces:

Spring cleaned issue: #6505
@vbraun vbraun mentioned this issue May 3, 2016
Closed
vbraun added a commit to vbraun/material that referenced this issue May 3, 2016
@vbraun
fix(chips): keypress handler for chips separator keys
d5edde1 
Chips separator keys can now either be numeric (and matched in the
keypress handler) or string (and matched in the keypress handler).

Closes angular#8319
vbraun added a commit to vbraun/material that referenced this issue May 3, 2016
@vbraun
fix(chips): keypress handler for chips separator keys
96027a2 
Chips separator keys can now either be numeric (and matched in the
keydown handler) or string (and matched in the keypress handler).

Closes angular#8319
@vbraun vbraun mentioned this issue May 3, 2016
Closed
@devversion devversion added the has: Pull Request A PR has been created to address this issue label May 3, 2016
vbraun added a commit to vbraun/material that referenced this issue May 7, 2016
@vbraun
fix(chips): keypress handler for chips separator keys
50e929c 
Chips separator keys can now either be numeric (and matched in the
keydown handler) or string (and matched in the keypress handler).

Closes angular#8319
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.1 May 18, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.1, Deprecated May 26, 2016
@ThomasBurleson
Copy link
Contributor

This issue is closed as part of our ‘Surge Focus on Material 2' efforts.
For details, see our forum posting @ http://bit.ly/1UhZyWs.

imz pushed a commit to imz/angular-material that referenced this issue Jan 25, 2018
@vbraun @imz
fix(chips): keypress handler for chips separator keys
662f0c6 
Chips separator keys can now either be numeric (and matched in the
keydown handler) or string (and matched in the keypress handler).

Closes angular#8319
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has: Pull Request A PR has been created to address this issue
Projects
None yet
Milestone
Deprecated
Development

No branches or pull requests
3 participants
@ThomasBurleson @vbraun @devversion