This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tooltip): cancel show timeouts when leaving before delay. #8394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When a user hovers over a tooltip, which has a delay, and we're leaving the tooltips parent before the delay is finished, then we're detaching all leave handlers, which is not valid. We should cancel the show timeout, when the leave occurs before the delay. Fixes angular#8363.
devversion
force-pushed
the
fix/tooltip-leave-before-delay
branch
from
6d53fbc to
7f97422
Compare
|
A codepen would be really useful here. |
ThomasBurleson
added
pr: merge ready
|
@devversion I wanted to review the PR, but I was not sure I would be able to understand the bug correctly from the textual description. A codepen example would have made it clear and unambiguous what the bug was and how to reproduce it. No matter no more... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should cancel the show timeout, when the leave occurs before the delay.
Fixes #8363.