This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): Fix autocomplete items with spaces. #8580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an autocomplete's item had spaces at the end, it would cause the autocomplete to show only the selected option when attempting to clear the value. This was caused because the `oninput` event that we fire was somehow resetting the value in the scope (after we had cleared it). Fix by resetting the scope back to an empty value after we fire the `oninput` event. Additionally, fix a few issues in the Virtual Repeat that was affecting the autocomplete and some test descriptions: - Add unwatcher in Virtual Repeat to fix angular#8178. - Use cached values in `$mdUtil.waitTransitionEnd()` to speed up performance and fix sizing issue in Virtual Repeat affecting the autocomplete. - Fix a few descriptions in the tests to be shorter/clearer and fix typos. Fixes angular#7655. Fixes angular#8178.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an autocomplete's item had spaces at the end, it would cause the autocomplete to show only the selected option when attempting to clear the value.
This was caused because the
oninputevent that we fire was somehow resetting the value in the scope (after we had cleared it). Fix by resetting the scope back to an empty value after we fire theoninputevent.Additionally, fix a few issues in the Virtual Repeat that was affecting the autocomplete and some test descriptions:
$mdUtil.waitTransitionEnd()to speed up performanceand fix sizing issue in Virtual Repeat affecting the autocomplete.
Fixes #7655. Fixes #8178.