This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(subheader): fix ng-show/hide directive on subheader #8648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the tests were mostly passing, because we always used the native sticky position. This commit adds decorator to tests, which forces the tests to use the $mdSticky service and its clone elements. * Now the tests are updated and cover all major use-case. All tests are passing, except angular#8647 (but this is a low priority) Fixes angular#8604.
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds decorator to tests, which forces the tests to use the $mdSticky service and its clone elements.
This guarantees that the subheaders will work properly in future changes.
Before, some tests didn't fail if something didn't work.
All tests are now passing, except #8647 (but this is a low priority)
Fixes #8604.