This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tooltip): improve the behavior on touch devices #8700
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Makes the tooltip more consistent on touch devices by not showing it when the element is tapped. * Doesn't bind extra mouse events if the device has a touchscreen, as well not adding touch events on a non-touch device. * Adds a constant about whether the device has a touchscreen. * Adds a default 75ms delay for touch devices, in order to prevent the tooltip from showing up for a split second when tapping. * Avoids potentially binding too many events on the parent element. Fixes angular#8642.
crisbeto
force-pushed
the
8642/tooltip-repeated-taps
branch
from
9210103 to
d53efb3
Compare
crisbeto
added
needs: review
ThomasBurleson
added
pr: merge ready
crisbeto
added a commit
to crisbeto/material
that referenced
this pull request
Jun 10, 2016
Reverts most of the changes from angular#8700 and switches to a simpler approach that uses a repeated `touchstart` to hide the tooltip, instead of `touchend`, which fires too early. Also re-enables mouse events for all kinds of devices, in order to cover cases where the devices has both a touchscreen and a mouse. Fixes angular#8710.
ThomasBurleson
pushed a commit
that referenced
this pull request
Jun 11, 2016
Reverts most of the changes from #8700 and switches to a simpler approach that uses a repeated `touchstart` to hide the tooltip, instead of `touchend`, which fires too early. Also re-enables mouse events for all kinds of devices, in order to cover cases where the devices has both a touchscreen and a mouse. Fixes #8710. Closes #8730
crisbeto
added a commit
to crisbeto/material
that referenced
this pull request
Jun 12, 2016
This is a follow-up to angular#8700 and angular#8730. It helps with the fact that we can't rely on the focus/blur events in touch devices, in order to hide the tooltip.
crisbeto
added a commit
to crisbeto/material
that referenced
this pull request
Jun 12, 2016
This is a follow-up to angular#8700 and angular#8730. It helps with the fact that we can't rely on the focus/blur events in touch devices, in order to hide the tooltip.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8642.