fix(menu): clean up the backdrop if the menu got destroyed mid-animation

[crisbeto]

The menu backdrop wasn't being cleaned up, if the menu got destroyed while it was animating.

Fixes #8727.

[crisbeto]

@devversion Could you give me some feedback on this since you were dealing with the interim elements?

[devversion]

It is quite unnormal to have a destroy listener inside of the interims onShow method.

[devversion]

@crisbeto Having a destroy listener here is not the correct solution.

Once the interim Element will be destroyed, the onRemove event will be called as well.
Also with the option options.$destroy (you don't need it for this case)

At #8727, an error will be thrown inside of a promise, which leads to a cancellation of the onRemove method.

The error will be thrown, because the cleanupInteraction method is not defined before the animation completes.

The fix would be

    function onRemove(scope, element, opts) {
      opts.cleanupInteraction && opts.cleanupInteraction();

[crisbeto]

Thanks, I'll give it another shot. If I remember correctly, the onRemove wasn't firing yesterday.

[devversion]

Sounds good! Yeah it will be triggered, I guess you checked the execution after the Runtime Exception.

[crisbeto]

That null check for the cleanupInteraction worked fine for the codepen from #8727 @devversion, but it didn't help when destroying the scope programmatically in the unit test. I also had to call the remove method in the directive's destroy listener.

[devversion]

@crisbeto Yeah, you're actually using the fix, because you're triggering the interimElements destroy function, which will come to the cleanupInteraction fix.

This is definitely the perfect solution. LGTM!