This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(chips): detect cursor position for selecting previous chip. #8791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently we check the truthyness of the chipBuffer, to confirm that the user is at the beginning of the chip input. Once he is at the beginning, we select and focus the previous chip, so the user can keep deleting the chips. * Checking for truthyness is not working, because Angular is trimming all ngModel values for the autocomplete and default chip input. This caused issues, where users can't delete their spaces in the input anymore. Checking the cursor position is more appropriated here, and works without affecting the autocomplete. This allows the autocomplete to work independently without any changes with the `md-chips` component. Fixes angular#8750
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once he is at the beginning, we select and focus the previous chip, so the user can keep deleting the chips.
This caused issues, where users can't delete their spaces in the input anymore.
Checking the cursor position is more appropriated here, and works without affecting the autocomplete.
This allows the autocomplete to work independently without any changes with the
md-chipscomponent.Tested with Chrome, Firefox and IE.
(Would be cool to test with #8752)
Fixes #8750