This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(tabs): properly detect text changes #8803
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the MutationObserver is watching for attribute changes and subtree modifications. It also watches for text content changes, but that's not working properly for span elements with `<md-tab-label>` elements. See https://bugzilla.mozilla.org/show_bug.cgi?id=1138368 The MutationObserver should watch for `characterData` to properly detect text changes. Fixes angular#8667.
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It also watches for text content changes, but that's not working properly for span elements with
<md-tab-label>elements.See for example https://bugzilla.mozilla.org/show_bug.cgi?id=1138368
The MutationObserver should watch for
characterDatato properly detect text changes.Fixes #8667.