This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(chips): Fix static chips remove padding. #8888
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Static chips had some erroneous "remove" padding due to some recent changes with the new `md-removable` feature. Fix by updating the `isRemovable()` method to also check if the component has an `ng-model` supplied and return false if not. Also, minor change to demo to provide slightly better feedback to the user. Fixes angular#8887.
topherfangio
added
needs: review
|
Even a better approach as the one we discussed. LGTM! |
|
@devversion Yeah; I started to do it in the template, but realized there were 3-4 places that would need to be updated, and this made more sense 😄 |
topherfangio
added
pr: merge ready
toshiakiezaki
pushed a commit
to toshiakiezaki/angular-material
that referenced
this pull request
Jul 1, 2016
Static chips had some erroneous "remove" padding due to some recent changes with the new `md-removable` feature. Fix by updating the `isRemovable()` method to also check if the component has an `ng-model` supplied and return false if not. Also, minor change to demo to provide slightly better feedback to the user. Fixes angular#8887. Closes angular#8888
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Static chips had some erroneous "remove" padding due to some recent changes with the new
md-removablefeature.Fix by updating the
isRemovable()method to also check if the component has anng-modelsupplied and return false if not.Also, minor change to demo to provide slightly better feedback to the user.
Fixes #8887.