This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(mixins): removed multilined comment #9002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EladBezalel
force-pushed
the
fix/multiline-comments-scss
branch
from
9860764 to
9488fa4
Compare
|
LGTM! - Also once thing I've noticed. It's actually not affecting the |
| @@ -205,6 +205,6 @@ function themeBuildStream() { | |||
| return gulp.src( config.themeBaseFiles.concat(path.join(config.paths, '*-theme.scss')) ) | |||
| .pipe(concat('default-theme.scss')) | |||
| .pipe(utils.hoistScssVariables()) | |||
| .pipe(sass()) | |||
There was a problem hiding this comment.
Node-sass does not like this:
stream.js:74
throw er; // Unhandled stream error in pipe.
^
Error: src/components/autocomplete/demoBasicUsage/index.html
Error: Invalid CSS after "...emoBasicUsage {": expected "}", was "<div ng-controller="
on line 1 of src/components/autocomplete/demoBasicUsage/index.html
>> .autocompletedemoBasicUsage {
-----------------------------^
at options.error (/Users/thomasburleson/Documents/projects/Google/projects/material/node_modules/node-sass/lib/index.js:272:32)Using node 6.3.
- some node versions with `node-sass` on windows can't compile it into 1 line
EladBezalel
force-pushed
the
fix/multiline-comments-scss
branch
from
9488fa4 to
c4eb955
Compare
|
@ThomasBurleson Still LGTM - Tracking the original issue with #9066 |
EladBezalel
changed the title
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-sasson windows can't compile it into 1 line