This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(input): icons not inheriting theme colors #9058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the `md-icon` instances inside of a `md-input-container` using the primary color, even though the container is e.g. `md-accent` or `md-warn`.
|
@EladBezalel Can you take a look at this? It seemed counter-intuitive that the input would have an "accent" color, but the icon would always stay with the "primary". I couldn't find anything about it in the spec. |
|
I think it's been noted here LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
md-iconinstances inside of amd-input-containerusing the primary color, even though the container is e.g.md-accentormd-warn.