This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat(layouts): add @mixin for responsive support for rows #9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
http://codepen.io/shortfuse/pen/AXyZLX (localhost test) |
clshortfuse
force-pushed
the
layout-whenRowMixin
branch
from
ebf07ae
to
ac19662
Compare
| @@ -326,3 +326,47 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| // Only use when in row layout | |||
| @mixin when-layout-row($element) { | |||
There was a problem hiding this comment.
This seems like a whole lot of selectors (close 1.5kb), for something as simple as drawing a divider.
There was a problem hiding this comment.
Right, I do have some PRs that would use this to fix issues with md-select, md-checkbox, md-input-container and md-datepicker. I had a tough time trying to squish it down though.
clshortfuse
added
the
in progress
|
I realized I should expand this to |
Create @mixin that allows different layout breakpoints Fixes angular#9112
clshortfuse
force-pushed
the
layout-whenRowMixin
branch
from
ac19662
to
b7c239c
Compare
clshortfuse
changed the title
clshortfuse
removed
the
in progress
|
Yeah, this is looking too bloated. Bumped radio-button from 3KB to 10KB. |
|
|
||
| // Only use when in row layout | ||
| @mixin when-layout-row($element, $parent: '') { | ||
| @media (max-width: 599px) { |
There was a problem hiding this comment.
we have variables for those breakpoints
|
Mistakenly merged... just now reverted from |
|
Rejected as invalid PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create @mixin that allows different layout breakpoints
Fixes #9112