Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(dialog): register close listeners before animation #9120

Closed
wants to merge 1 commit into from
Closed

fix(dialog): register close listeners before animation #9120

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

  • Registering the close listeners before the animation has started improves the UX.
    If the user presses escape before the dialog is actually open, it feels like a freeze and non-response.

R: @EladBezalel

Fixes #9096.

@devversion
fix(dialog): register close listeners before animation
791a32a 
* Registering the close listeners before the animation has started improves the UX.
  If the user presses escape before the dialog is actually open, it feels like a freeze and non-response.

Fixes angular#9096.
@devversion devversion added the needs: review This PR is waiting on review from the team label Jul 23, 2016
@EladBezalel
Copy link
Member

LGTM

@EladBezalel EladBezalel mentioned this pull request Jul 24, 2016
Closed
@devversion devversion deleted the fix/dialog-register-listeners-before branch July 24, 2016 17:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ThomasBurleson ThomasBurleson

Labels
needs: review This PR is waiting on review from the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$mdDialog.show() is freezed after show/hide
3 participants
@devversion @EladBezalel @ThomasBurleson