This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(input): Add missing Polyfill for ng1.3 and fix tests. #9169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Angular 1.3 apparently did not include the `AnimateRunner.all()` method. Grab it from latest 1.5.8 code and add to our 1.3 polyfills. Additional, our $animateCss polyfill for 1.3 modifies the `to` and `from` options that are passed in and sets them to `null`. This was causing the tests to fail. Fix by keeping a cloned reference for test purposes.
topherfangio
added
needs: review
|
@topherfangio is this optional if you are using 1.5.x? |
|
@epelc This should only be included if your Angular version is < 1.4 (so 1.3 and earlier). You having issues in 1.5? |
|
@topherfangio I meant could we make this optional(along with any other polyfills) if we do not require them? Perhaps moving to some sort of No issues. Just wanted to make the build size a little bit smaller for me and anyone else using a newer version of angular. |
|
@epelc Ah, gotcha. At the moment, no, we don't provide a way to easily remove them, but I'll chat with the team about it this next week and see what they say. |
|
@topherfangio I made an issue for you to reference #9378 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular 1.3 apparently did not include the
AnimateRunner.all()method. Grab it from latest 1.5.8 code and add to our 1.3 polyfills.Additional, our $animateCss polyfill for 1.3 modifies the
toandfromoptions that are passed in and sets them tonull. This was causing the tests to fail. Fix by keeping a cloned reference for test purposes.