This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(bottom-sheet): add isLockedOpen option; general cleanup #9179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -189,16 +197,15 @@ function MdBottomSheetProvider($$interimElementProvider) { | |||
| $animate.enter(backdrop, options.parent, null); | |||
| } | |||
|
|
|||
| var bottomSheet = new BottomSheet(element, options.parent); | |||
| options.bottomSheet = bottomSheet; | |||
| options.cleanupGestures = options.isLockedOpen ? angular.noop : new BottomSheetGestures(element, options.parent); | |||
There was a problem hiding this comment.
This is pretty unclear.
if (!options.isLockedOpen) {
options.cleanupGestures = registerGestures(element, options.parent);
}
options.cleanupGestures && options.cleanupGestures()
function registerGestures(element, parent) {
...
}There was a problem hiding this comment.
I agree about the naming, but the main reason I decided to default to a noop was to make the API consistent, no matter the options.
There was a problem hiding this comment.
It doesn't make any sense to have a noop function here. Check for example the dialog interim element / component.
Regarding API, the options are not any API for the developers. At time of show those are just internal and used to store things between the different states.
There was a problem hiding this comment.
Ah right, I confused it with the hide/cancel/show on the service. I'll switch it up.
crisbeto
force-pushed
the
9084/bottom-sheet-is-open
branch
from
6485ec0
to
3c8ea26
Compare
| var bottomSheet = new BottomSheet(element, options.parent); | ||
| options.bottomSheet = bottomSheet; | ||
| if (!options.isLockedOpen) { | ||
| options.cleanupGestures = registerGestures(element, options.parent); |
There was a problem hiding this comment.
Actually after looking again at the PR, can't you move that declaration up to the isLockedOpen check and use a else?
if (options.isLockedOpen) {
options.clickOutsideToClose = false;
options.escapeToClose = false;
} else {
options.cleanupGestures = registerGestures(element, options.parent);
}There was a problem hiding this comment.
I will, another good point 👍
|
LGTM aside from the one comment. |
crisbeto
force-pushed
the
9084/bottom-sheet-is-open
branch
from
3c8ea26
to
3eb8762
Compare
* Adds the `isLockedOpen` option to the bottom sheet service, allowing users to disable all non-programmatic ways of closing a bottom sheet. * Cleans up some redundant logic in the mdBottomSheet service. * Cleans up the bottom sheet unit test setup. Fixes angular#9084.
crisbeto
force-pushed
the
9084/bottom-sheet-is-open
branch
from
3eb8762
to
9000bb7
Compare
Splaktar
added
pr: lgtm
chmelevskij
pushed a commit
to chmelevskij/material
that referenced
this pull request
Jun 19, 2018
…#9179) * Adds the `isLockedOpen` option to the bottom sheet service, allowing users to disable all non-programmatic ways of closing a bottom sheet. * Cleans up some redundant logic in the mdBottomSheet service. * Cleans up the bottom sheet unit test setup. Fixes angular#9084.
Splaktar
pushed a commit
that referenced
this pull request
Jul 31, 2018
* Adds the `isLockedOpen` option to the bottom sheet service, allowing users to disable all non-programmatic ways of closing a bottom sheet. * Cleans up some redundant logic in the mdBottomSheet service. * Cleans up the bottom sheet unit test setup. Fixes #9084.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLockedOpenoption to the bottom sheet service, allowing users to disable all non-programmatic ways of closing a bottom sheet.Fixes #9084.