This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(): refactor rtl-prop mixin to add less CSS #9218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactors the rtl-prop mixin to include less CSS. * Changes all the instances where it was used to incorporate the new syntax. **Note:** There are a few instances where the mixin seems used redundantly. These aren't the objective of this PR. Fixes angular#9217.
| @@ -125,15 +125,10 @@ | |||
| } | |||
| } | |||
|
|
|||
| @mixin rtl-prop($ltr-prop, $rtl-prop, $value) { | |||
| @mixin rtl-prop($ltr-prop, $rtl-prop, $value, $reset-value) { | |||
There was a problem hiding this comment.
I would say you should add a null default:
@mixin rtl-prop($ltr-prop, $rtl-prop, $value, $reset-value: null) {
That was, we can make some segments with even less CSS.
http://www.sassmeister.com/gist/b87f3d64603d5bceaa29534ffc585457
Edit: Actually, on second inspection, can't think of a use for not specifying a reset value.
There was a problem hiding this comment.
The point of the PR isn't to reduce the CSS as much as possible, but rather to remove the redundancies while staying as close to the old functionality as possible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There are a few instances where the mixin seems used redundantly. These aren't the objective of this PR.
Fixes #9217.