Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(build): switch to cssnano for CSS optimizations #9236

Closed
wants to merge 1 commit into from

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 4, 2016

Replaces the deprecated gulp-minify-css with gulp-cssnano.

Fixes #9225.

CC @topherfangio, @devversion, @EladBezalel

Some notes after comparing the output to the one from our previous build:

  • The builds take a few seconds longer, but the minified file size is reduced by about 6kb.
  • It does shuffle around some styles, but it seems to be playing it pretty safe so I doubt that it'll break anything.
  • Apparently the old minifier that we were using was converting instances of outline: none to outline: 0. Now the value is preserved properly, but that'll be a minor difference in the output, compared to before. We could go through and convert the values if needed.

Replaces the deprecated `grunt-minify-css` with `gulp-cssnano`.

Fixes angular#9225.
@crisbeto crisbeto added the needs: review This PR is waiting on review from the team label Aug 4, 2016
@topherfangio
Copy link
Contributor

@crisbeto Can you include some of the notes you mentioned during our meeting so we have a bit more info? Particularly interested in your comparisons.

Otherwise, LGTM 👍

@crisbeto
Copy link
Member Author

crisbeto commented Aug 4, 2016

Updated.

@devversion
Copy link
Member

LGTM as well.

@crisbeto crisbeto added the P0: critical Critical issues that must be addressed immediately. label Aug 4, 2016
@crisbeto crisbeto added this to the 1.1.0 milestone Aug 4, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.0, 1.1.1 Aug 5, 2016
@crisbeto crisbeto removed the P0: critical Critical issues that must be addressed immediately. label Aug 5, 2016
@jelbourn
Copy link
Member

LGTM!

@jelbourn jelbourn added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Aug 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants