This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): fix a couple of js errors and log a warning if the display value isn't a string #9251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
9242/autocomplete-warning
branch
from
17e3eb3 to
53235b7
Compare
| var itemText = getItemText(item) || item; | ||
|
|
||
| if (itemText && !angular.isString(itemText)) { | ||
| $log.warn('Could not resolve display value to a string. Please check the `md-item-text` attribute.'); |
There was a problem hiding this comment.
Can we please prefix that (probably like this) ?
md-autocomplete: The resolved text for an item is not a string. Please check the `md-item-text` attribute.`
There was a problem hiding this comment.
Good idea, I'll put it in.
crisbeto
force-pushed
the
9242/autocomplete-warning
branch
from
53235b7 to
b512d66
Compare
| return $q.when(getItemText(item) || item); | ||
| var itemText = getItemText(item) || item; | ||
|
|
||
| if (itemText && !angular.isString(itemText)) { |
There was a problem hiding this comment.
I'm not really sure about that check, because $scope.itemText can also return a promise as a value.
http://codepen.io/DevVersion/pen/KrGxaQ (Simple example)
I think it would be better to chain into the returned promise and add the check there.
There was a problem hiding this comment.
Thanks, I didn't know that was a use case.
… display value isn't a string * Fixes a couple of JS errors in the autocomplete that were caused by assumptions that the input would always be a string. * Adds a warning for cases where the display value doesn't evaluate to a string. * Cleans up a few redundant expressions. **Note:** There's still a JS error when clearing the value, but it should be fixed with angular#9221. Fixes angular#9242.
crisbeto
force-pushed
the
9242/autocomplete-warning
branch
from
b512d66 to
cf42ba2
Compare
|
LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There's still a JS error when clearing the value, but it should be fixed with #9221.
Fixes #9242.