This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(checkbox): Undefined ng-checked value now shows as unchecked. #9281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change caused an undefined `ng-checked` value to style the checkbox as checked via the `md-checked` CSS class. - Add appropriate test. - Fix check to cast value to a boolean first. - Fix indentation of watch statement. Fixes angular#9280.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change caused an undefined
ng-checkedvalue to style the checkbox as checked via themd-checkedCSS class.Fixes #9280.
Ping @ErinCoughlan, @ThomasBurleson and @EladBezalel for review.