This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): do not compile an empty element when using a content element #9303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment I recently noticed while playing with the pre-rendered dialog around, that despite of the pre-rendered dialog, the interim element triggers a compilation in the `$mdCompiler`. It doesn't introduce any bugs, but it's unnecessary and could damage the performance. Also moves the content element stuff into its own function, which makes the source more clean and allows us to maintain it easily.
devversion
force-pushed
the
fix/dialog-pre-rendered-compile
branch
from
2ee1824 to
144fb38
Compare
|
overall lgtm |
|
Dangerous changes... needs thorough manual testing. |
ThomasBurleson
added
the
needs: manual testing
|
LGTM code-wise, haven't tried running it. |
EladBezalel
removed
the
needs: manual testing
|
Tested manually, everything is working |
ThomasBurleson
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed while playing with the pre-rendered dialog around, that despite of the pre-rendered dialog, the interim element triggers a compilation in the
$mdCompiler.It doesn't introduce any bugs, but it's unnecessary and could damage the performance.
Also moves the content element stuff into its own function, which makes the source more clean and allows us to maintain it easily.
Plays nicely together with #9299.
cc. @EladBezalel @topherfangio