This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(prefixer): do not throw an exception if element is undefined #9345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
| * @param element {JQLite|Element} Element to be parsed | ||
| * @returns {HTMLElement} Parsed HTMLElement | ||
| */ | ||
| function _parseElement(element) { |
There was a problem hiding this comment.
parse isn't really the right word. It implies that you're taking a string recognizing it into something else. I'd use _getNativeElement
* The prefixer currently throws an error, when the jqLite element / native element is empty / undefined. This was noticeable when having a `md-fab-actions` element without any child elements.
devversion
force-pushed
the
fix/prefixer-do-not-throw
branch
from
ea4eba7 to
bba84b3
Compare
|
LGTM |
jelbourn
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was noticeable when having a
md-fab-actionselement without any child elements.FYI: Checking the
nodeTypeis more elegant, than comparing the prototype. It's the same way jQuery uses as well.cc. @ErinCoughlan