This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(theming): fix read-only $mdThemingProvider.configuration() #9389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ThomasBurleson
commented
Aug 23, 2016
ThomasBurleson
commented
- insure we clone properly the a configuration map object.
- implement unit test to verify.
ThomasBurleson
added
the
pr: merge ready
|
@jelbourn - ping |
ThomasBurleson
force-pushed
the
wip/fix-themingProvider
branch
from
1787cf2 to
8758424
Compare
| return angular.extend( { }, config, locals ); | ||
| var config = angular.extend( { }, themeConfig, locals ); | ||
|
|
||
| config.registeredStyles = [].concat(config.registeredStyles); |
|
LGTM aside from that one indentation thing |
ThomasBurleson
force-pushed
the
wip/fix-themingProvider
branch
from
8758424 to
f6d5c6b
Compare
|
@jelbourn - fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.