fix(layout): Revert overzealous IE11 flexbox fix. #9412
Conversation
A recent change which was supposed to fix an IE11 bug accidentally altered the `flex-basis` for the flex children of all `.layout-column` flex containers in all browsers. Unfortunately, there is no IE11-specific fix. - Revert the original change. - Update the Layout Troubleshooting page with a new demo. - Update the Layout Children docs to mention the new demo. - Remove old Chrome-specific demo which was incidentally fixed by reverting this change. Reverts ce0ebbf. Fixes angular#9354.
| content. This is particularly noticable if you have a non-flex item (say a toolbar), followed by | ||
| two flex items in a column layout. | ||
| In Internet Explorer 11, when you have a column layout with unspecified height and flex items | ||
| inside, the browser can get confused and incorrectly calculate the height of each item (and thus |
There was a problem hiding this comment.
I'm not really sure, but should that be and incorrectly calculates?
There was a problem hiding this comment.
Random English Silliness
I honestly think either would work here, but how I judge it is this: remove the "get confused and" phrase to see how it sounds:
the browser can incorrectly calculate the height...
verses
the browser can incorrectly calculates the height...
Honestly, seeing as I've never seen it not get confused, it might be more correct to just say
the browser gets confused and incorrectly calculates the height...
Stupid english 😝
There was a problem hiding this comment.
lol, thanks for the explanation 😄 Keep whatever you think. You are the native speaker!
Probably some german habit
|
That looks very good to me. Especially how everything is explained with an associated demo. |
|
@topherfangio - lgtm, nice work here sir! |
ThomasBurleson
added
pr: merge ready
A recent change which was supposed to fix an IE11 bug accidentally altered the
flex-basisfor the flex children of all.layout-columnflex containers in all browsers.Unfortunately, there is no IE11-specific fix.
by reverting this change.
Reverts ce0ebbf.
Fixes #9354.