-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(tabs): support flexible content layout #9451
Conversation
I feel like this might break some existing users who expect it to be block? Also, have you tested this across all the browsers we support to make sure it works as expected? |
@topherfangio OK on Chrome, Firefox, IE 10, IE11 and Edge. The reason I didn't just use |
2eb54e9
to
655417b
Compare
I've reworked this to not use mdLayout and instead the This should not break layouts since user content is wrapped by We are also using |
c78b71f
to
45864ab
Compare
Certain browsers had issues with resizing tab content md-tabs' parent would change size or have an unspecified size during creation (for example in a dialog). Converting to flexbox solves this issue. * Set md-tab-content to flexbox * Set md-tab-content's div to fill parent * Set md-pagination-wrapper to flexbox Fixes angular#9206, angular#9704, angular#9779
45864ab
to
2326d4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Certain browsers had issues with resizing tab content md-tabs' parent
would change size or have an unspecified size during creation (for
example in a dialog). Converting to flexbox solves this issue.
Fixes #9206, #9704, #9779