This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(dialog): add extra classes to identify buttons #9463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds classes to help identify the confirmation and close buttons in a dialog. This helps with writing tests that involve the dialog, because it doesn't depend on DOM order.
crisbeto
added
needs: review
|
LGTM |
|
thanks for this! |
|
LGTM 👍 |
ThomasBurleson
added
g3: reported
ThomasBurleson
added
the
pr: merge ready
|
1024 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds classes to help identify the confirmation and close buttons in a dialog. This helps with writing tests that involve the dialog, because it doesn't depend on DOM order.
CC @ErinCoughlan