This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(util): disableScrollAround should not remove disabled scroll mask #9547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
needs: rebase
|
|
||
| return $mdUtil.disableScrollAround._enableScrolling = function() { | ||
| return $mdUtil.disableScrollAround._restoreScroll = function() { | ||
| if (!--$mdUtil.disableScrollAround._count) { |
There was a problem hiding this comment.
This seems dangerous. How about
if ( --$mdUtil.disableScrollAround._count < 1 ) {
....
}There was a problem hiding this comment.
Yeah will change while I'm at it.
ThomasBurleson
added
in progress
* When the scroll mask is disabled per the new options which were recently added, the specified element will be used as scroll mask (under the hood) If restoring scroll, the scroll mask will be removed from the DOM (even the disabled one) - This is invalid. This causes an issue when restoring the scroll, while the element is still showing up (e.g dialog with z-index)
devversion
force-pushed
the
fix/util-not-remove-if-scrollmask
branch
from
1f78786
to
cbe27a9
Compare
devversion
added
needs: review
|
@ThomasBurleson Addressed the comments you added. |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
crisbeto
added a commit
to crisbeto/material
that referenced
this pull request
Sep 24, 2016
…oll mask (angular#9547)" This reverts commit bbb9ec5.
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Oct 8, 2016
…angular#9547) * When the scroll mask is disabled per the new options which were recently added, the specified element will be used as scroll mask (under the hood) If restoring scroll, the scroll mask will be removed from the DOM (even the disabled one) - This is invalid. This causes an issue when restoring the scroll, while the element is still showing up (e.g dialog with z-index)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If restoring scroll, the scroll mask will be removed from the DOM (even the disabled one) - This is invalid.
This causes an issue when restoring the scroll, while the element is still showing up (e.g dialog with z-index)
@ThomasBurleson Also I need to correct my self, the issue within the
$mdPanelis not reproducable (but present), because the element will be anyways detached by the panel.Part of #9256