This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(layout): fix use of flex-basis in layout modes #9572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
force-pushed
the
wip/layout-flex-basis-fix
branch
from
937f852 to
453517c
Compare
ThomasBurleson
added
ui: layout
ui: responsive
needs: review
Manual testing anomaliesHome pagelocalhost
head
Checkbox syncing demolocalhost
head
Colors Theming Demolocalhost
head
Whiteframe Directive Interpolation DemolocalhostBREAKING head
Css Typographylocalhost
head
Layout Childrenlocalhost
head
Layout Troubleshootinglocalhost
head
|
|
I went through it as well. Basically got the same as @EladBezalel |
|
@EladBezalel, @crisbeto - thx |
ThomasBurleson
added
needs: work
in progress
ThomasBurleson
force-pushed
the
wip/layout-flex-basis-fix
branch
from
453517c to
af5d99b
Compare
ThomasBurleson
added
needs: review
|
@EladBezalel - please review again. All above ^ should be fixed/resolved. |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Oct 8, 2016
Fix use of `flex-basis` when setting the max-width or max-height values. This allows `flex-offset` to work flex items correctly stretched. Fixes angular#5345. Closes angular#9572
vologab
added a commit
to vologab/material
that referenced
this pull request
Mar 3, 2017
)" This reverts commit c6fb5a5.
|
#10345 🎎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix use of
flex-basiswhen setting the max-width or max-height values.This allows
flex-offsetto work flex items correctly stretched.Fixes #5345.