This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
fix(switch): invalid container margin in RTL #9586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Sep 12, 2016
devversion
commented
- The switch does not properly display in RTL mode - this is due to the recent changes to the RTL mixin, which introduced a reset value.
- Inside of the switch the container should have a 0px reset value
| Before | After |
|---|---|
 |
 |
* The switch does not properly display in RTL mode - this is due to the recent changes to the RTL mixin, which introduced a reset value. * Inside of the switch the container should have a 0px reset value
|
LGTM The |
| @@ -44,7 +44,7 @@ md-switch { | |||
| height: $switch-height; | |||
| position: relative; | |||
| user-select: none; | |||
| @include rtl-prop(margin-right, margin-left, 8px, auto); | |||
| @include rtl-prop(margin-right, margin-left, 8px, 0px); | |||
There was a problem hiding this comment.
nit: use 0 instead of 0px (minifying CSS will do this anyway)
ThomasBurleson
added
needs: presubmit
and removed
needs: review
Frank3K
pushed a commit
to Frank3K/material
that referenced
this pull request
Oct 8, 2016
* The switch does not properly display in RTL mode - this is due to the recent changes to the RTL mixin, which introduced a reset value. * Inside of the switch the container should have a 0px reset value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.