This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(panel): consolidate redundant validations #9631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
the
needs: rebase
* The panel has the `_validateXPosition` and `_validateYPosition` methods which do the exact same thing, except on a different object. This moves that logic to a function in order to avoid the duplicated code. * Removes a use of double equals in the validation function.
crisbeto
force-pushed
the
panel-redundant-checks
branch
from
9a23e0f to
6d80a2e
Compare
crisbeto
removed
the
needs: rebase
|
@ThomasBurleson this should also be ready for presubmit. |
Splaktar
added
pr: lgtm
Splaktar
added
P2: required
googlebot
added
the
cla: yes
Splaktar
removed
the
needs: rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_validateXPositionand_validateYPositionmethods which do the exact same thing, except on a different object. This moves that logic to a function in order to avoid the duplicated code.CC @ErinCoughlan @bradrich