fix(autocomplete): apply theming to input element #9698

mckenzielong · 2016-09-27T03:40:08Z

mckenzielong · 2016-09-27T03:44:31Z

@devversion similar to what we discussed in #9447 as option 1, but this isn't a full solution... I realized that the loading bar wouldn't be covered by this case (for example docs + accent yields proper coloured input, but incorrect styled loading bar)

We could filter the classes (md-warn and md-accent) as you mentioned and forward those to the input container and loading bar -- a similar solution could be applicable to md-input-container + md-select.

Edit: or I can add in the progress-linear css

devversion

I've added two comments, those should make the review easier after.

devversion · 2016-09-30T22:16:50Z

src/components/autocomplete/js/autocompleteDirective.js

@@ -218,6 +218,7 @@ function MdAutocomplete ($$mdSvgRegistry) {
        // Retrieve the state of using a md-not-found template by using our attribute, which will
        // be added to the element in the template function.
        ctrl.hasNotFound = !!element.attr('md-has-not-found');
+        $mdTheming(element);


Why do we need to do this again? The controller already does register the theme.

https://github.com/angular/material/blob/master/src/components/autocomplete/js/autocompleteController.js#L70

devversion · 2016-09-30T22:17:19Z

src/components/autocomplete/autocomplete-theme.scss

+        background-color: '{{warn-color}}';
+      }
+    }
+  }


If we are doing something like that, then we should create a mixin for it, so we don't have to repeat it three times.

@devversion not sure if you mean in autocomplete-theme.scss or if you mean on in input and linear progress that could be included?

Was hoping that the mixins used in md-tabs would have been a good starting point -- upon closer inspection they just repeated the same code in mixins:

material/src/components/tabs/tabs-theme.scss

Line 1 in 317c1c8

@mixin md-tab-primary {

<- were you looking for something more like that?

Yeah I meant something like that 👍 This just removes the unnecessary repetitions and it's easier to maintain.

devversion · 2016-10-03T10:05:06Z

I just pulled the PR and tried it out. Seems like the progress bar did not get the correct color.

mckenzielong · 2016-10-04T01:52:58Z

@devversion Sorry, my bad. Fixed.

devversion · 2016-10-10T15:47:12Z

I tried it out and it works 👍 Still not a fan of that solution, but it might be easiest for now.

Splaktar · 2018-08-17T08:38:28Z

@mckenzielong I'm sorry that this got stuck for so long. If you can rebase it, I'd be happy to try to get this merged in 1.1.11.

If you rebase, please update the commit to include the existing first line plus a blank line and then Fixes #9447.

If you aren't able to rebase it, I can try to take over this work and get it updated merged in.

mckenzielong · 2018-08-20T14:50:33Z

@Splaktar i'll take a look 👍

Fixes angular#9447

Splaktar

LGTM. Verified with manual testing in light and dark modes. Thank you very much for this contribution! Sorry for the delay in getting it merged.

…r#9698)

mckenzielong force-pushed the fix-autocomplete-input branch from 52d08c9 to 9a459d5 Compare September 27, 2016 04:10

devversion suggested changes Sep 30, 2016

View reviewed changes

devversion added in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs needs: review This PR is waiting on review from the team labels Sep 30, 2016

mckenzielong force-pushed the fix-autocomplete-input branch 2 times, most recently from 14a955e to dcb8aef Compare October 3, 2016 06:33

devversion self-assigned this Oct 3, 2016

mckenzielong force-pushed the fix-autocomplete-input branch from dcb8aef to da3027b Compare October 4, 2016 01:50

devversion removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Oct 10, 2016

devversion approved these changes Oct 10, 2016

View reviewed changes

ThomasBurleson modified the milestones: 1.1.3, 1.2.0 Jan 1, 2017

Splaktar assigned Splaktar and unassigned devversion Aug 17, 2018

Splaktar modified the milestones: Future, 1.1.11 Aug 17, 2018

Splaktar added needs: manual testing This issue or PR needs to have some manual testing and verification done type: bug ui: theme P2: required Issues that must be fixed. ux: integration and removed needs: review This PR is waiting on review from the team labels Aug 17, 2018

Splaktar added the needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved label Aug 17, 2018

Splaktar changed the title ~~fix(mdAutocomplete): apply theming to input element~~ fix(autocomplete): apply theming to input element Aug 17, 2018

googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Aug 20, 2018

mckenzielong force-pushed the fix-autocomplete-input branch from da3027b to b5d2150 Compare August 20, 2018 15:23

fix(autocomplete): apply themes to mdProgressLinear and input

e5bb719

Fixes angular#9447

mckenzielong force-pushed the fix-autocomplete-input branch from b5d2150 to e5bb719 Compare August 20, 2018 15:24

Splaktar removed the needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved label Aug 20, 2018

Splaktar mentioned this pull request Aug 24, 2018

autocomplete: input element should use the same theme #9447

Closed

Splaktar approved these changes Aug 24, 2018

View reviewed changes

Splaktar added pr: merge ready This PR is ready for a caretaker to review and removed needs: manual testing This issue or PR needs to have some manual testing and verification done labels Aug 24, 2018

Splaktar assigned jelbourn Aug 24, 2018

Splaktar added the pr: lgtm This PR has been approved by the reviewer label Aug 24, 2018

Splaktar assigned josephperrott and unassigned jelbourn Sep 4, 2018

josephperrott merged commit affe84b into angular:master Sep 4, 2018

nobitagit pushed a commit to nobitagit/material that referenced this pull request Sep 24, 2018

fix(autocomplete): apply themes to mdProgressLinear and input (angula…

592be01

…r#9698)

marosoft pushed a commit to marosoft/material that referenced this pull request Nov 11, 2018

fix(autocomplete): apply themes to mdProgressLinear and input (angula…

f694387

…r#9698)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(autocomplete): apply theming to input element #9698

fix(autocomplete): apply theming to input element #9698

Uh oh!

mckenzielong commented Sep 27, 2016

Uh oh!

mckenzielong commented Sep 27, 2016 •

edited

Loading

Uh oh!

devversion left a comment

Uh oh!

devversion Sep 30, 2016

Uh oh!

devversion Sep 30, 2016

Uh oh!

mckenzielong Oct 3, 2016

Uh oh!

devversion Oct 3, 2016

Uh oh!

devversion commented Oct 3, 2016 •

edited

Loading

Uh oh!

mckenzielong commented Oct 4, 2016

Uh oh!

devversion commented Oct 10, 2016 •

edited

Loading

Uh oh!

Splaktar commented Aug 17, 2018 •

edited

Loading

Uh oh!

mckenzielong commented Aug 20, 2018

Uh oh!

Splaktar left a comment

Uh oh!

Uh oh!

fix(autocomplete): apply theming to input element #9698

fix(autocomplete): apply theming to input element #9698

Uh oh!

Conversation

mckenzielong commented Sep 27, 2016

Uh oh!

mckenzielong commented Sep 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devversion left a comment

Choose a reason for hiding this comment

Uh oh!

devversion Sep 30, 2016

Choose a reason for hiding this comment

Uh oh!

devversion Sep 30, 2016

Choose a reason for hiding this comment

Uh oh!

mckenzielong Oct 3, 2016

Choose a reason for hiding this comment

Uh oh!

devversion Oct 3, 2016

Choose a reason for hiding this comment

Uh oh!

devversion commented Oct 3, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mckenzielong commented Oct 4, 2016

Uh oh!

devversion commented Oct 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Splaktar commented Aug 17, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mckenzielong commented Aug 20, 2018

Uh oh!

Splaktar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mckenzielong commented Sep 27, 2016 •

edited

Loading

devversion commented Oct 3, 2016 •

edited

Loading

devversion commented Oct 10, 2016 •

edited

Loading

Splaktar commented Aug 17, 2018 •

edited

Loading