This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(docs): prevent tabbing over hidden content; better animation handling #9773
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
type: docs
a11y
|
@EladBezalel , @devversion, @topherfangio - who can test the A11Y fixes for this ? |
ThomasBurleson
added
needs: manual testing
|
@ThomasBurleson I'll do some testing for the a11y today. |
|
Tested on Firefox/NVDA and IE11/JAWS. LGTM on both 👍 |
…ling * Fixes users being able to tab through the hidden content on the docs site. * Switches the docs site's menu accordions to use `$animateCss` for their transitions. This allows us to reliably know when an animation has started and finished. This approach also avoids having to trigger multiple nested timeouts. Fixes angular#8896.
crisbeto
force-pushed
the
8896/docs-menu-tabbing
branch
from
2d2f034 to
a89fd05
Compare
ThomasBurleson
added
needs: presubmit
and removed
in progress
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$animateCssfor their transitions. This allows us to reliably know when an animation has started and finished.Fixes #8896.