This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(card): fix alignment with avatar icons in Safari #9801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari has an alignment issue with SVG icons when its parent has any padding, causing its content to shift placement * Force SVG elements to inherit height and width properties. Fixes angular#9147
clshortfuse
added
ui: CSS
needs: review
|
Review with: http://codepen.io/shortfuse/full/GjxLYj/ Tested OK on IE 11, Safari 9, Chrome 53, Firefox 49, Android 4.4.2 If somebody knows an alternative |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
|
@clshortfuse I don't see a |
|
@topherfangio The idea being, if we are targeting a Safari issue, we would ideally limit the CSS to just Safari. The only possible solution I found the one in the commit, that was applies to all browsers. As I said before, though, I didn't notice any issue in any of our supported browsers. |
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari has an alignment issue with SVG icons when its parent has
any padding, causing its content to shift placement
Fixes #9147