This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(datepicker,select): arrow button consistency #9807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes the datepicker's arrow being off a few pixels inside `md-input-container`, as well as being too close to the bottom when not in a `md-input-container`. * Fixes the select's arrow icon being too dark, because it inherits from the closest `color` rule. Relates to angular#9798.
|
|
||
| // TODO(jelbourn): This position isn't great on all platforms. | ||
| @include rtl(transform, translateY(-25%) translateX(45%), translateY(-25%) translateX(-45%)); | ||
| @include rtl(transform, translateX(45%), translateX(-45%)); |
There was a problem hiding this comment.
Does this happen to fix the TODO above it?
There was a problem hiding this comment.
I'm not really sure what the TODO is referring to. I removed it since it's unnecessary.
|
This looks good, but what demo can we look at to see the changes? Or was your image from a Codepen? |
|
My image is from me running the docs site locally. I shuffled some HTML around in the input demo. |
ThomasBurleson
added
needs: presubmit
and removed
needs: review
kara
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-input-container, as well as being too close to the bottom when not in amd-input-container.colorrule.Relates to #9798.
For reference, here's what it looked like before:
And here's what it looks like after:
