This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(datepicker): ensure that all month/year elements have the expected height #9893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
added
P0 - Presubmit First
and removed
needs: review
|
@jelbourn - ping for final review. |
jelbourn
reviewed
Oct 24, 2016
| // The <tr> ensures that the <tbody> will always have the | ||
| // proper height, even if it's empty. If it's content is | ||
| // compiled, the <tr> will be overwritten. | ||
| '<tr style="height:' + TBODY_HEIGHT + 'px;"></tr>' + |
There was a problem hiding this comment.
Empty <tr> should have aria-hidden
…d height The datepicker's calendar uses `md-virtual-repeat` to render itself. The virtual repeater expects that all elements that it has rendered will have a certain height, however this may not be the case if it renders an empty month/year element in the calendar. If this happens (it's usually if the current value and the maximum date are in the same month), the calendar can start jumping while scrolling. This change adds an empty `<tr>` that will ensure that even empty elements have a height. When the element is compiled, the empty `<tr>` will be overwritten. Fixes angular#9863.
crisbeto
force-pushed
the
9863/datepicker-scroll-jump
branch
from
be22fd7 to
de5e7e9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The datepicker's calendar uses
md-virtual-repeatto render itself. The virtual repeater expects that all elements that it has rendered will have a certain height, however this may not be the case if it renders an empty month/year element in the calendar. If this happens (it's usually if the current value and the maximum date are in the same month), the calendar can start jumping while scrolling.This change adds an empty
<tr>that will ensure that even empty elements have a height. When the element is compiled, the empty<tr>will be overwritten.Fixes #9863.