Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

fix(demo): autocomplete to use global stylesheet for demo #9930

Merged
merged 1 commit into from Nov 7, 2016

Conversation

devversion
Copy link
Member

@devversion devversion commented Oct 27, 2016

This PR changes

  • Duplicate Autocomplete CSS (in docs.css and demo css - confusing)
  • Also shows style.global.css with the shorthand CSS (as with the normal style.css)
  • Removes unused CSS class in the autocomplete demo (demo-metastat - confusing)

Details why to change to style.global.css

Currently the md-autocomplete demo for the custom templates needs to have a CSS for the dropdown (which is outside of the demo container)

The normal style.css file does not work here, because the CSS get's encapsulated by our Build Process.

The build process automatically does not encapsulate the CSS if the file is style.global.css (same as done for the panel demos)

Changes for all demos currently using style.global.css

Old New

Fixes #9920

Currently the `md-autocomplete` demo for the custom templates needs to have a CSS for the dropdown (which is outside of the demo container)

The normal `style.css` file does not work here, because the CSS get's encapsulated by our Build Process.

The build process automatically does not encapsulate the CSS if the file is `style.global.css` (same as done for the panel demos)

This commit changes
* Duplicate Autocomplete CSS (in docs.css and demo css - confusing)
* Also shows `style.global.css` with the shorthand `CSS` (as with the normal `style.css`
* Removes unused CSS class in the autocomplete demo (`demo-metastat` - confusing)

Fixes angular#9920
@devversion devversion added the needs: review This PR is waiting on review from the team label Oct 27, 2016
@ThomasBurleson ThomasBurleson added this to the 1.1.2 milestone Oct 27, 2016
@devversion devversion removed the needs: review This PR is waiting on review from the team label Nov 7, 2016
@devversion devversion changed the title fix(autocomplete): use global stylesheet for demo fix(demo): autocomplete to use global stylesheet for demo Nov 7, 2016
@ThomasBurleson ThomasBurleson merged commit e807a3b into angular:master Nov 7, 2016
@devversion devversion deleted the fix/autocomplete-demo branch November 7, 2016 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants