Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

feat(select): add the ability to pre-select the only option in the list #9940

Merged
merged 3 commits into from
Apr 30, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 28, 2016

  • Adds the md-select-only-option attribute, that will cause <md-select> to pre-select the first option, if it only has one option in it's list.
  • Fixes an ugly way of adding extra classes to the select container.
  • Removes a few variables and arguments that weren't being used.

Fixes #9626.

@crisbeto crisbeto force-pushed the 9626/select-only-option branch from 127badb to 81b7781 Compare October 28, 2016 20:57
@crisbeto crisbeto added the needs: review This PR is waiting on review from the team label Oct 28, 2016
@ThomasBurleson
Copy link
Contributor

@crisbeto - please verify this PR is still valid/needed and rebase. Thank you.

@ThomasBurleson ThomasBurleson added needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved and removed needs: review This PR is waiting on review from the team labels Jan 1, 2017
@ThomasBurleson ThomasBurleson modified the milestone: 1.1.3 Jan 1, 2017
* Adds the `md-select-only-option` attribute, that will cause `<md-select>` to pre-select the first option, if it only has one option in it's list.
* Fixes an ugly way of adding extra classes to the select container.
* Removes a few variables and arguments that weren't being used.

Fixes angular#9626.
@crisbeto crisbeto force-pushed the 9626/select-only-option branch from 81b7781 to 4cdbb65 Compare January 1, 2017 19:27
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Jan 1, 2017
@crisbeto crisbeto added needs: review This PR is waiting on review from the team and removed needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved labels Jan 1, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Jan 1, 2017

It's rebased @ThomasBurleson.

@ThomasBurleson ThomasBurleson modified the milestones: 1.1.3, 1.2.0 Jan 3, 2017
@Splaktar Splaktar self-requested a review April 22, 2020 05:05
@Splaktar Splaktar assigned Splaktar and unassigned ThomasBurleson Apr 22, 2020
@Splaktar Splaktar modified the milestones: Future, 1.1.23 Apr 22, 2020
@Splaktar Splaktar added the P3: important Important issues that really should be fixed when possible. label Apr 22, 2020
Copy link
Contributor

@Splaktar Splaktar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added type: enhancement pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Apr 28, 2020
@Splaktar Splaktar requested a review from jelbourn April 28, 2020 00:37
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Apr 30, 2020
@Splaktar Splaktar merged commit 6372027 into angular:master Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P3: important Important issues that really should be fixed when possible. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select: select option if there is only 1 option
5 participants