This repository was archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
feat(select): add the ability to pre-select the only option in the list #9940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127badb
to
81b7781
Compare
@crisbeto - please verify this PR is still valid/needed and rebase. Thank you. |
* Adds the `md-select-only-option` attribute, that will cause `<md-select>` to pre-select the first option, if it only has one option in it's list. * Fixes an ugly way of adding extra classes to the select container. * Removes a few variables and arguments that weren't being used. Fixes angular#9626.
81b7781
to
4cdbb65
Compare
It's rebased @ThomasBurleson. |
Splaktar
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jelbourn
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
P3: important
Important issues that really should be fixed when possible.
pr: lgtm
This PR has been approved by the reviewer
pr: merge ready
This PR is ready for a caretaker to review
type: enhancement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
md-select-only-option
attribute, that will cause<md-select>
to pre-select the first option, if it only has one option in it's list.Fixes #9626.