Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

Conversation

Azahe
Copy link
Contributor

@Azahe Azahe commented Nov 10, 2016

The available space beneath a wrap included space above viewport. When heights of the body
and viewport did not match (e.g. on mobile) dropdown was displayed on the wrong side.
This change make it so available space is calculated properly.

Fixes #10188

The available space beneath a wrap included space above viewport. When heights of the body
and viewport did not match (e.g. on mobile) dropdown was displayed on the wrong side.
This change make it so available space is calculated properly.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@Azahe
Copy link
Contributor Author

Azahe commented Nov 10, 2016

How about now googlebot? :)

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@clshortfuse
Copy link
Contributor

clshortfuse commented Dec 22, 2016

@Azahe can you file an issue for this with an example? This is so we can better test the PR.

@clshortfuse clshortfuse self-assigned this Dec 22, 2016
@clshortfuse clshortfuse added the needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community label Dec 22, 2016
@Azahe
Copy link
Contributor Author

Azahe commented Dec 28, 2016

@clshortfuse Hey, sorry for late response (christmas) - I made a quick example of what I meant: https://codepen.io/Azahe/pen/ObeGrg (assembled from https://material.angularjs.org/latest/demo/autocomplete)

And issue: #10188

@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Dec 28, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.3, 1.2.0 Jan 1, 2017
@ThomasBurleson ThomasBurleson added needs: presubmit and removed needs: investigation The cause of this issue is not well understood and needs to be investigated by the team or community labels Mar 7, 2017
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.4, 1.2.0 Mar 7, 2017
@mmalerba mmalerba merged commit 9f198c9 into angular:master Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants