Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

docs: links from header directives are not compatible with base URL #11634

Merged
merged 1 commit into from
Feb 8, 2019
Merged

docs: links from header directives are not compatible with base URL #11634

merged 1 commit into from
Feb 8, 2019

Conversation

Splaktar
Copy link
Member

@Splaktar Splaktar commented Feb 8, 2019 •
edited
Loading

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The header links often bring the user to the wrong part of the correct docs page or they just take the user to the AngularJS Material home page instead of the specific part of the docs that was intended.
Additionally, copying the links from the anchors results in a bad URL.

Issue Number:
Fixes #11285

What is the new behavior?

  • anchor URLs now are relative to base defined in <head>.
  • anchor links can now be copied and shared
  • fix a11y contrast issue with visited header links on toolbars

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@Splaktar
docs: links from header directives are not compatible with base URL
40eefc4 
fix a11y contrast issue with visited header links on toolbars

Fixes #11285
@Splaktar Splaktar added this to the 1.1.13 milestone Feb 8, 2019
@Splaktar Splaktar self-assigned this Feb 8, 2019
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Feb 8, 2019
@Splaktar Splaktar added pr: merge ready This PR is ready for a caretaker to review P2: required Issues that must be fixed. labels Feb 8, 2019
jelbourn
jelbourn approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit 4148550 into master Feb 8, 2019
@Splaktar Splaktar deleted the demos-demoLinksBroken branch February 8, 2019 23:38
@Splaktar Splaktar mentioned this pull request Feb 20, 2019
Closed
Splaktar added a commit that referenced this pull request Feb 21, 2019
@Splaktar
docs: properly format anchor names and hrefs
e9ca928 
anchor names should not include any path info
hrefs need to include the baseURL in addition to the path

Fixes #11644. Relates to #11634. Relates to #11285.
@Splaktar Splaktar mentioned this pull request Feb 21, 2019
Merged
3 tasks
jelbourn pushed a commit that referenced this pull request Feb 23, 2019
@Splaktar @jelbourn
docs: properly format anchor names and hrefs (#11648)
163b762 
anchor names should not include any path info
hrefs need to include the baseURL in addition to the path

Fixes #11644. Relates to #11634. Relates to #11285.
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Feb 23, 2019
Merged
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@Splaktar Splaktar

Labels
cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: docs
Projects
None yet
Milestone
1.1.13
Development

Successfully merging this pull request may close these issues.

docs: header links are not working
3 participants
@Splaktar @jelbourn @googlebot