Skip to content

Commit 221c234

Browse files
tinayuangaojelbourn
authored andcommitted
fix(progress-spinner): Rename ProgressCircle to ProgressSpinner (#2300)
* Rename ProgressCircle to ProgressSpinner * Make old selectors work * Added progres-circle file
1 parent bde8734 commit 221c234

28 files changed

+125
-120
lines changed

e2e/components/progress-circle/progress-circle.e2e.ts

Lines changed: 0 additions & 17 deletions
This file was deleted.
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
import {browser, by, element} from 'protractor';
2+
3+
describe('progress-spinner', () => {
4+
beforeEach(() => browser.get('/progress-spinner'));
5+
6+
it('should render a determinate progress spinner', () => {
7+
expect(element(by.css('md-progress-spinner')).isPresent()).toBe(true);
8+
});
9+
10+
it('should render an indeterminate progress spinner', () => {
11+
expect(element(by.css('md-progress-spinner[mode="indeterminate"]')).isPresent()).toBe(true);
12+
});
13+
14+
it('should render a spinner', () => {
15+
expect(element(by.css('md-spinner')).isPresent()).toBe(true);
16+
});
17+
});

src/demo-app/demo-app-module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import {CardDemo} from './card/card-demo';
1616
import {ChipsDemo} from './chips/chips-demo';
1717
import {RadioDemo} from './radio/radio-demo';
1818
import {ButtonToggleDemo} from './button-toggle/button-toggle-demo';
19-
import {ProgressCircleDemo} from './progress-circle/progress-circle-demo';
19+
import {ProgressSpinnerDemo} from './progress-spinner/progress-spinner-demo';
2020
import {TooltipDemo} from './tooltip/tooltip-demo';
2121
import {ListDemo} from './list/list-demo';
2222
import {BaselineDemo} from './baseline/baseline-demo';
@@ -74,7 +74,7 @@ import {InputContainerDemo} from './input/input-container-demo';
7474
OverlayDemo,
7575
PortalDemo,
7676
ProgressBarDemo,
77-
ProgressCircleDemo,
77+
ProgressSpinnerDemo,
7878
ProjectionDemo,
7979
ProjectionTestComponent,
8080
RadioDemo,

src/demo-app/demo-app/demo-app.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ export class DemoApp {
3939
{name: 'Portal', route: 'portal'},
4040
{name: 'Projection', route: 'projection'},
4141
{name: 'Progress Bar', route: 'progress-bar'},
42-
{name: 'Progress Circle', route: 'progress-circle'},
42+
{name: 'Progress Spinner', route: 'progress-spinner'},
4343
{name: 'Radio', route: 'radio'},
4444
{name: 'Ripple', route: 'ripple'},
4545
{name: 'Select', route: 'select'},

src/demo-app/demo-app/routes.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {CheckboxDemo} from '../checkbox/checkbox-demo';
1515
import {OverlayDemo} from '../overlay/overlay-demo';
1616
import {PortalDemo} from '../portal/portal-demo';
1717
import {ProgressBarDemo} from '../progress-bar/progress-bar-demo';
18-
import {ProgressCircleDemo} from '../progress-circle/progress-circle-demo';
18+
import {ProgressSpinnerDemo} from '../progress-spinner/progress-spinner-demo';
1919
import {SelectDemo} from '../select/select-demo';
2020
import {SidenavDemo} from '../sidenav/sidenav-demo';
2121
import {SlideToggleDemo} from '../slide-toggle/slide-toggle-demo';
@@ -45,7 +45,7 @@ export const DEMO_APP_ROUTES: Routes = [
4545
{path: 'sidenav', component: SidenavDemo},
4646
{path: 'slide-toggle', component: SlideToggleDemo},
4747
{path: 'slider', component: SliderDemo},
48-
{path: 'progress-circle', component: ProgressCircleDemo},
48+
{path: 'progress-spinner', component: ProgressSpinnerDemo},
4949
{path: 'progress-bar', component: ProgressBarDemo},
5050
{path: 'portal', component: PortalDemo},
5151
{path: 'projection', component: ProjectionDemo},

src/demo-app/progress-circle/progress-circle-demo.html

Lines changed: 0 additions & 21 deletions
This file was deleted.
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
<h1>Determinate</h1>
2+
<div class="demo-progress-spinner">
3+
<md-progress-spinner mode="determinate"
4+
[value]="progressValue"
5+
class="md-primary"></md-progress-spinner>
6+
<md-progress-spinner [value]="progressValue"
7+
color="accent"></md-progress-spinner>
8+
</div>
9+
<span>Value: {{progressValue}}</span>
10+
<button md-raised-button (click)="step(10)">Increase</button>
11+
<button md-raised-button (click)="step(-10)">Decrease</button>
12+
13+
14+
15+
<h1>Indeterminate</h1>
16+
<div class="demo-progress-spinner">
17+
<md-progress-spinner mode="indeterminate"></md-progress-spinner>
18+
<md-progress-spinner mode="indeterminate"
19+
color="accent"></md-progress-spinner>
20+
<md-spinner></md-spinner>
21+
</div>

src/demo-app/progress-circle/progress-circle-demo.scss renamed to src/demo-app/progress-spinner/progress-spinner-demo.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
.demo-progress-circle {
1+
.demo-progress-spinner {
22
width: 100%;
33

4-
md-progress-circle,
4+
md-progress-spinner,
55
md-spinner {
66
display: inline-block;
77
}

src/demo-app/progress-circle/progress-circle-demo.ts renamed to src/demo-app/progress-spinner/progress-spinner-demo.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ import {Component} from '@angular/core';
33

44
@Component({
55
moduleId: module.id,
6-
selector: 'progress-circle-demo',
7-
templateUrl: 'progress-circle-demo.html',
8-
styleUrls: ['progress-circle-demo.css'],
6+
selector: 'progress-spinner-demo',
7+
templateUrl: 'progress-spinner-demo.html',
8+
styleUrls: ['progress-spinner-demo.css'],
99
})
10-
export class ProgressCircleDemo {
10+
export class ProgressSpinnerDemo {
1111
progressValue: number = 40;
1212

1313
step(val: number) {

src/e2e-app/e2e-app-module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {DialogE2E, TestDialog} from './dialog/dialog-e2e';
1212
import {GridListE2E} from './grid-list/grid-list-e2e';
1313
import {ListE2E} from './list/list-e2e';
1414
import {ProgressBarE2E} from './progress-bar/progress-bar-e2e';
15-
import {ProgressCircleE2E} from './progress-circle/progress-circle-e2e';
15+
import {ProgressSpinnerE2E} from './progress-spinner/progress-spinner-e2e';
1616
import {MaterialModule} from '@angular/material';
1717
import {E2E_APP_ROUTES} from './e2e-app/routes';
1818
import {SlideToggleE2E} from './slide-toggle/slide-toggle-e2e';
@@ -38,7 +38,7 @@ import {SlideToggleE2E} from './slide-toggle/slide-toggle-e2e';
3838
GridListE2E,
3939
ListE2E,
4040
ProgressBarE2E,
41-
ProgressCircleE2E,
41+
ProgressSpinnerE2E,
4242
SlideToggleE2E
4343
],
4444
bootstrap: [E2EApp],

src/e2e-app/e2e-app/e2e-app.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
<a md-list-item [routerLink]="['list']">List</a>
1010
<a md-list-item [routerLink]="['menu']">Menu</a>
1111
<a md-list-item [routerLink]="['progress-bar']">Progress bar</a>
12-
<a md-list-item [routerLink]="['progress-circle']">Progress circle</a>
12+
<a md-list-item [routerLink]="['progress-spinner']">Progress Spinner</a>
1313
<a md-list-item [routerLink]="['radio']">Radios</a>
1414
<a md-list-item [routerLink]="['slide-toggle']">Slide Toggle</a>
1515
<a md-list-item [routerLink]="['tabs']">Tabs</a>

src/e2e-app/e2e-app/routes.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {DialogE2E} from '../dialog/dialog-e2e';
1010
import {GridListE2E} from '../grid-list/grid-list-e2e';
1111
import {ListE2E} from '../list/list-e2e';
1212
import {ProgressBarE2E} from '../progress-bar/progress-bar-e2e';
13-
import {ProgressCircleE2E} from '../progress-circle/progress-circle-e2e';
13+
import {ProgressSpinnerE2E} from '../progress-spinner/progress-spinner-e2e';
1414
import {SlideToggleE2E} from '../slide-toggle/slide-toggle-e2e';
1515

1616
export const E2E_APP_ROUTES: Routes = [
@@ -25,6 +25,6 @@ export const E2E_APP_ROUTES: Routes = [
2525
{path: 'grid-list', component: GridListE2E},
2626
{path: 'list', component: ListE2E},
2727
{path: 'progress-bar', component: ProgressBarE2E},
28-
{path: 'progress-circle', component: ProgressCircleE2E},
28+
{path: 'progress-spinner', component: ProgressSpinnerE2E},
2929
{path: 'slide-toggle', component: SlideToggleE2E}
3030
];

src/e2e-app/progress-circle/progress-circle-e2e.html

Lines changed: 0 additions & 3 deletions
This file was deleted.

src/e2e-app/progress-circle/progress-circle-e2e.ts

Lines changed: 0 additions & 8 deletions
This file was deleted.
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
<md-progress-spinner [value]="57"></md-progress-spinner>
2+
<md-progress-spinner mode="indeterminate"></md-progress-spinner>
3+
<md-spinner></md-spinner>
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
import {Component} from '@angular/core';
2+
3+
@Component({
4+
moduleId: module.id,
5+
selector: 'progress-spinner-e2e',
6+
templateUrl: 'progress-spinner-e2e.html',
7+
})
8+
export class ProgressSpinnerE2E { }

src/lib/core/theming/_all-theme.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
@import '../../list/list-theme';
1414
@import '../../menu/menu-theme';
1515
@import '../../progress-bar/progress-bar-theme';
16-
@import '../../progress-circle/progress-circle-theme';
16+
@import '../../progress-spinner/progress-spinner-theme';
1717
@import '../../radio/radio-theme';
1818
@import '../../select/select-theme';
1919
@import '../../sidenav/sidenav-theme';
@@ -40,7 +40,7 @@
4040
@include md-list-theme($theme);
4141
@include md-menu-theme($theme);
4242
@include md-progress-bar-theme($theme);
43-
@include md-progress-circle-theme($theme);
43+
@include md-progress-spinner-theme($theme);
4444
@include md-radio-theme($theme);
4545
@include md-select-theme($theme);
4646
@include md-sidenav-theme($theme);

src/lib/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export * from './input/index';
1313
export * from './list/index';
1414
export * from './menu/index';
1515
export * from './progress-bar/index';
16-
export * from './progress-circle/index';
16+
export * from './progress-spinner/index';
1717
export * from './radio/index';
1818
export * from './select/index';
1919
export * from './sidenav/index';

src/lib/module.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import {MdGridListModule} from './grid-list/index';
2424
import {MdCardModule} from './card/index';
2525
import {MdChipsModule} from './chips/index';
2626
import {MdIconModule} from './icon/index';
27-
import {MdProgressCircleModule} from './progress-circle/index';
27+
import {MdProgressSpinnerModule} from './progress-spinner/index';
2828
import {MdProgressBarModule} from './progress-bar/index';
2929
import {MdInputModule} from './input/index';
3030
import {MdSnackBarModule} from './snack-bar/snack-bar';
@@ -50,7 +50,7 @@ const MATERIAL_MODULES = [
5050
MdListModule,
5151
MdMenuModule,
5252
MdProgressBarModule,
53-
MdProgressCircleModule,
53+
MdProgressSpinnerModule,
5454
MdRadioModule,
5555
MdRippleModule,
5656
MdSelectModule,
@@ -82,7 +82,7 @@ const MATERIAL_MODULES = [
8282
MdInputModule.forRoot(),
8383
MdListModule.forRoot(),
8484
MdProgressBarModule.forRoot(),
85-
MdProgressCircleModule.forRoot(),
85+
MdProgressSpinnerModule.forRoot(),
8686
MdRippleModule.forRoot(),
8787
MdSelectModule.forRoot(),
8888
MdSidenavModule.forRoot(),

src/lib/progress-circle/index.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

src/lib/progress-circle/_progress-circle-theme.scss renamed to src/lib/progress-spinner/_progress-spinner-theme.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
@import '../core/theming/theming';
33

44

5-
@mixin md-progress-circle-theme($theme) {
5+
@mixin md-progress-spinner-theme($theme) {
66
$primary: map-get($theme, primary);
77
$accent: map-get($theme, accent);
88
$warn: map-get($theme, warn);
99

10-
md-progress-circle, md-spinner {
10+
md-progress-spinner, md-progress-circle, md-spinner {
1111
path {
1212
stroke: md-color($primary, 600);
1313
}

src/lib/progress-spinner/index.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export * from './progress-circle';
2+
export * from './progress-spinner';
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
/** @deprecated */
2+
export {MdProgressSpinner as MdProgressCircle} from './progress-spinner';
3+
/** @deprecated */
4+
export {MdProgressSpinnerModule as MdProgressCircleModule} from './progress-spinner';

src/lib/progress-circle/progress-circle.scss renamed to src/lib/progress-spinner/progress-spinner.scss

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,22 @@
22

33

44
// Animation Durations
5-
$md-progress-circle-duration: 5250ms !default;
6-
$md-progress-circle-constant-rotate-duration: $md-progress-circle-duration * 0.55 !default;
7-
$md-progress-circle-sporadic-rotate-duration: $md-progress-circle-duration !default;
5+
$md-progress-spinner-duration: 5250ms !default;
6+
$md-progress-spinner-constant-rotate-duration: $md-progress-spinner-duration * 0.55 !default;
7+
$md-progress-spinner-sporadic-rotate-duration: $md-progress-spinner-duration !default;
88

99
// Component sizing
10-
$md-progress-circle-stroke-width: 10px !default;
11-
// Height and weight of the viewport for md-progress-circle.
12-
$md-progress-circle-viewport-size: 100px !default;
10+
$md-progress-spinner-stroke-width: 10px !default;
11+
// Height and weight of the viewport for md-progress-spinner.
12+
$md-progress-spinner-viewport-size: 100px !default;
1313

1414

1515
:host {
1616
display: block;
17-
// Height and width are provided for md-progress-circle to act as a default.
17+
// Height and width are provided for md-progress-spinner to act as a default.
1818
// The height and width are expected to be overwritten by application css.
19-
height: $md-progress-circle-viewport-size;
20-
width: $md-progress-circle-viewport-size;
19+
height: $md-progress-spinner-viewport-size;
20+
width: $md-progress-spinner-viewport-size;
2121
overflow: hidden;
2222

2323
// SVG's viewBox is defined as 0 0 100 100, this means that all SVG children will placed
@@ -34,15 +34,15 @@ $md-progress-circle-viewport-size: 100px !default;
3434
fill: transparent;
3535

3636
// Stroke width of 10px defines stroke as 10% of the viewBox.
37-
stroke-width: $md-progress-circle-stroke-width;
37+
stroke-width: $md-progress-spinner-stroke-width;
3838
}
3939

4040

4141
&[mode='indeterminate'] svg {
42-
animation-duration: $md-progress-circle-sporadic-rotate-duration,
43-
$md-progress-circle-constant-rotate-duration;
44-
animation-name: md-progress-circle-sporadic-rotate,
45-
md-progress-circle-linear-rotate;
42+
animation-duration: $md-progress-spinner-sporadic-rotate-duration,
43+
$md-progress-spinner-constant-rotate-duration;
44+
animation-name: md-progress-spinner-sporadic-rotate,
45+
md-progress-spinner-linear-rotate;
4646
animation-timing-function: $ease-in-out-curve-function,
4747
linear;
4848
animation-iteration-count: infinite;
@@ -52,11 +52,11 @@ $md-progress-circle-viewport-size: 100px !default;
5252

5353

5454
// Animations for indeterminate mode
55-
@keyframes md-progress-circle-linear-rotate {
55+
@keyframes md-progress-spinner-linear-rotate {
5656
0% { transform: rotate(0deg); }
5757
100% { transform: rotate(360deg); }
5858
}
59-
@keyframes md-progress-circle-sporadic-rotate {
59+
@keyframes md-progress-spinner-sporadic-rotate {
6060
12.5% { transform: rotate( 135deg); }
6161
25% { transform: rotate( 270deg); }
6262
37.5% { transform: rotate( 405deg); }

0 commit comments

Comments
 (0)