Skip to content

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 8, 2018

Adds the mat-icon-rtl-mirror CSS class that can be used to mirror icons only in an RTL layout.

Fixes #10045.

Adds the `mat-icon-rtl-mirror` CSS class that can be used to mirror icons only in an RTL layout.

Fixes angular#10045.
@crisbeto crisbeto requested a review from jelbourn as a code owner March 8, 2018 14:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 8, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

In the future I could see making this an input and adding a MAT_ICON_OPTIONS provider like we have for other components, but this is good for now (and could easily be backwards compatible w/ changing it in the future).

@crisbeto
Copy link
Member Author

crisbeto commented Mar 8, 2018

I wanted to avoid having an input that just toggles a class (I think we've had that discussion before). As for configuring it globally, I didn't do it because not all icons should be mirrored.

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release and removed pr: needs review labels Mar 8, 2018
@jelbourn jelbourn merged commit 11a3fe1 into angular:master Mar 9, 2018
@philip-firstorder
Copy link

This is simple, efficient and flexible. Solves our problems.
Would be cool if the material icons page can also add a rtl flag in the details for each icon. So we know if it is recommended to mirror it on rtl.
I will open a ticket there for this.

@philip-firstorder
Copy link

I found a list of icons that can be mirrored here: http://google.github.io/material-design-icons/#icons-in-rtl

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons are not mirrored on RTL
4 participants