fix(autosize): textarea receiving focus on init #11460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes autosizeable textareas receiving focus when they're initialized. Fixes angular#11451. Fixes angular#11308.
googlebot
added
the
cla: yes
|
Hehe, too fast for me, was just about to send my PR in ;-) Having the same exact check on the activeDocument. Tests with firefox still pass, so for what it's worth, LGTM. |
mmalerba
approved these changes
May 22, 2018
mmalerba
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
May 24, 2018
|
Hi All , I recently updated my angular material and still facing this issue. I'm using "@angular/material": "^6.4.2" and was wondering if the fix for this issue is part of this version. If yes, kindly let me know if updating to the material will resolve the issue or do I have to update more dependencies. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes autosizeable textareas receiving focus when they're initialized.
Fixes #11451.
Fixes #11308.