-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Closed
Labels
P4A relatively minor issue that is not relevant to core functionsA relatively minor issue that is not relevant to core functionsarea: material/toolbarfeatureThis issue represents a new feature or feature request rather than a bug or bug fixThis issue represents a new feature or feature request rather than a bug or bug fixtarget: majorThis PR is targeted for the next major releaseThis PR is targeted for the next major release
Description
Bug, feature request, or proposal:
feature request
What is the expected behavior?
Toolbar should be migrated to top-bar, there should be no toolbar component
What is the current behavior?
Toolbar, but no top- or bottom-bar
What is the use-case or motivation for changing an existing behavior?
The spec has been updated to not include a toolbar, instead allowing for "App bars", both top- and bottom-.
Is there anything else we should know?
MDC is also doing this, and it is being tracked here
Tasks
- Scaffold empty classes, assets, demo, build config, etc.
- Stub existing component API
- Hook up MDC foundation and adapter
- Add remaining features on top of MDC implementation
- Test dark theme
- Test RTL
- Test with screen-readers
- Copy existing unit tests and ensure they all pass
- Copy existing e2e tests and ensure they all pass (if any)
- Verify SSR support in universal-app/
- Verify no size regression
- Create test harness
- Create schematics for migration
- Create user documentation
Additional notes
Breaking changes
Known issues & visual differences
Splaktar, rabbitism, splitt3r, mhosman, sylvaindumont and 2 moremhosman and RenatoFrancamhosman and RenatoFrancamhosman and RenatoFranca
Metadata
Metadata
Assignees
Labels
P4A relatively minor issue that is not relevant to core functionsA relatively minor issue that is not relevant to core functionsarea: material/toolbarfeatureThis issue represents a new feature or feature request rather than a bug or bug fixThis issue represents a new feature or feature request rather than a bug or bug fixtarget: majorThis PR is targeted for the next major releaseThis PR is targeted for the next major release